feat: Added filter to applicable VMSS ARG queries to filter out AKS managed VMSSs #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 suggestion.
Files not reviewed (1)
- azure-resources/Compute/virtualMachineScaleSets/kql/1422c567-782c-7148-ac7c-5fc14cf45adc.kql: Evaluated as low risk
Comments skipped due to low confidence (1)
azure-resources/Compute/virtualMachineScaleSets/kql/94794d2a-eff0-2345-9b67-6f9349d0a627.kql:9
- The use of
ifffunction is redundant.isemptyalready returns a boolean value. Simplify the code to| where isempty(tostring(tags['aks-managed-poolName'])).
| where iff(isempty(tostring(tags['aks-managed-poolName'])), true, false)
azure-resources/Compute/virtualMachineScaleSets/kql/94794d2a-eff0-2345-9b67-6f9349d0a627.kql
Outdated
Show resolved
Hide resolved
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
judyer28
changed the title
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
microsoft-github-policy-service
bot
added
the
Enhancement 🆕
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
|
|
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
judyer28
requested a deployment
to
BuildObject
GitHub Actions
Waiting
|
Thanks @judyer28! LGTM |
oZakari
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- azure-resources/Compute/virtualMachineScaleSets/kql/1422c567-782c-7148-ac7c-5fc14cf45adc.kql: Evaluated as low risk
hannah-leland
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
A majority of the VMSS ARG queries do not apply to VMSS that are managed by AKS. This PR adds a filter to applicable ARG queries to filter out AKS managed VMSSs. The filter looks for a tag "aks-managed-poolName" on the VMSS. If it is there then it is considered a managed AKS VMSS. The line below is the filter used to ensure AKS VMSS are not considered as part of the VMSS recommendations.
| where isempty(tostring(tags['aks-managed-poolName']))
Related Issues/Work Items
Fixes AB#38580
Breaking Changes
As part of this pull request I have
mainbranch