Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added section for Azure AI with 3 recommendations #555

Merged
merged 8 commits into from
Dec 13, 2024
Merged

feat: Added section for Azure AI with 3 recommendations #555

merged 8 commits into from
Dec 13, 2024

Conversation

khushal08
Copy link
Contributor

Overview/Summary

Created a new section for Azure AI with first three recommendations

Related Issues/Work Items

Breaking Changes

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings December 9, 2024 03:37
@khushal08 khushal08 requested a review from a team as a code owner December 9, 2024 03:37
Copilot
Copilot AI reviewed Dec 9, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no suggestions.

Files not reviewed (5)
  • azure-resources/ArtificialIntelligence/AI/recommendations.yaml: Language not supported
  • azure-resources/ArtificialIntelligence/AI/kql/0c193899-da60-4a52-b4a0-77d75ac8c5c5.kql: Evaluated as low risk
  • azure-resources/ArtificialIntelligence/AI/kql/8aa9744b-f302-4b05-9776-51d6dd3d0c3a.kql: Evaluated as low risk
  • azure-resources/ArtificialIntelligence/AI/kql/ac3add17-013e-41a5-af91-9fefce794a00.kql: Evaluated as low risk
  • azure-specialized-workloads/ai/kql/0c193899-da60-4a52-b4a0-77d75ac8c5c5.kql: Evaluated as low risk
ejhenry
ejhenry reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushal08 let me know if you have any questions about my comments.

azure-resources/ArtificialIntelligence/AI/_index.md Outdated Show resolved Hide resolved
azure-resources/ArtificialIntelligence/AI/recommendations.yaml Outdated Show resolved Hide resolved
azure-resources/ArtificialIntelligence/AI/recommendations.yaml Outdated Show resolved Hide resolved
azure-resources/ArtificialIntelligence/AI/recommendations.yaml Outdated Show resolved Hide resolved
azure-specialized-workloads/ai/recommendations.yaml Outdated Show resolved Hide resolved
azure-specialized-workloads/ai/recommendations.yaml Outdated Show resolved Hide resolved
azure-specialized-workloads/ai/recommendations.yaml Outdated Show resolved Hide resolved
@ejhenry ejhenry added Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Dec 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Dec 11, 2024
@khushal08
Copy link
Contributor Author

@ejhenry Modified based on the feedback

@ejhenry ejhenry changed the title Added section for Azure AI with 3 APRL recommendations feat: Added section for Azure AI with 3 APRL recommendations Dec 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Dec 12, 2024
@oZakari oZakari closed this Dec 12, 2024
@oZakari oZakari reopened this Dec 12, 2024
oZakari
oZakari previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari deployed to BuildObject December 12, 2024 05:04 — with GitHub Actions Active
@oZakari oZakari closed this Dec 12, 2024
@oZakari oZakari reopened this Dec 12, 2024
ejhenry
ejhenry approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry changed the title feat: Added section for Azure AI with 3 APRL recommendations feat: Added section for Azure AI with 3 recommendations Dec 13, 2024
@ejhenry ejhenry merged commit 771fd5e into Azure:main Dec 13, 2024
8 of 10 checks passed
@khushal08 khushal08 deleted the AOAI-38365-PAYG branch December 13, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@ejhenry ejhenry ejhenry approved these changes

@oZakari oZakari oZakari approved these changes

@Rajani-Janaki-Ram Rajani-Janaki-Ram Awaiting requested review from Rajani-Janaki-Ram

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation Enhancement 🆕 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khushal08 @oZakari @ejhenry @Rajani-Janaki-Ram