Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: PG Sign off completed for two remaining VM recommendations. Change Impact from Low to Medium for one of those two recommendations as well. #512

Merged
merged 4 commits into from
Nov 12, 2024
Merged

docs: PG Sign off completed for two remaining VM recommendations. Change Impact from Low to Medium for one of those two recommendations as well. #512

merged 4 commits into from
Nov 12, 2024

Conversation

hannah-leland
Copy link
Contributor

@hannah-leland hannah-leland commented Nov 7, 2024 •
edited
Loading

Overview/Summary

PG Sign off completed for two remaining VM recommendations. Change Impact from Low to Medium for one of those two recommendations as well.

Related Issues/Work Items

N/A

Breaking Changes

None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@hannah-leland hannah-leland requested a review from a team as a code owner November 7, 2024 19:01
@hannah-leland hannah-leland changed the title PG Sign off completed for two remaining VM recommendations. Change Impact from Low to Medium for one of those two recommendations as well. docs: PG Sign off completed for two remaining VM recommendations. Change Impact from Low to Medium for one of those two recommendations as well. Nov 7, 2024
@oZakari oZakari closed this Nov 11, 2024
@oZakari oZakari reopened this Nov 11, 2024
@oZakari
Copy link
Collaborator

oZakari commented Nov 11, 2024

LGTM

oZakari
oZakari approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari added Area: Resource Guidance 📝 Improvements or additions to documentation Enhancement 🆕 New feature or request Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. and removed Enhancement 🆕 New feature or request labels Nov 11, 2024
ejhenry
ejhenry approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit 3ea28ad into Azure:main Nov 12, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry approved these changes

@oZakari oZakari oZakari approved these changes

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannah-leland @oZakari @ejhenry