Updating Terraform templates for Azure Firewall with Private Endpoints #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating random string, KV and secret
Changing Warning note.
Update readme.md
Removing hard coded password
Removing hard coded password, adding KV and secret.
Update HubAndSpoke.tf
Removing hard coded password, adding KV and secret
Update SingleVnet.tf
gumoden
requested review from
tobystic,
andrewmathuj,
david-frazee and
shabaz-github
as code owners
david-frazee
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing hard coded passwords, creating a random string for each deployment, new Azure KeyVault and Secrets.