Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code Improvement #828

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Update Code Improvement #828

merged 3 commits into from
Nov 13, 2023

Conversation

Jefajers
Copy link
Member

@Jefajers Jefajers commented Nov 9, 2023

Overview/Summary

This PR contains improvements in the following areas: PSScriptAnalyzer Warnings, Subscription ApiVersion, ManagementGroup enumeration performance improvement and GitHub Actions Checkout version change from v3 to v4.

This PR fixes/adds/changes/removes

  1. Changes dependencies.yml
  2. Changes release.yml
  3. Changes super-linter.yml
  4. Changes tests.yml
  5. Changes wiki-sync.yml
  6. Removes ARMAzOpsSetup.ps1
  7. Changes Dependencies.ps1
  8. Changes Remove-AzOpsTestsDeployment.ps1
  9. Changes Get-AzOpsManagementGroup.ps1
  10. Changes Get-AzOpsSubscription.ps1
  11. Changes Strings.psd1
  12. Changes tests/functional/Microsoft.Management/managementGroups/deploy/deploy.ps1

Breaking Changes

  1. N/A

Testing Evidence

General module tests have been performed and tests of Checkout version changes without issues. It would be ideal to have some extra check of ARMAzOpsSetup.ps1 behavior's before merge.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added enhancement New feature or request do-not-merge Not ready to merge labels Nov 9, 2023
@Jefajers Jefajers added this to the Release - v2.3.1 milestone Nov 9, 2023
@Jefajers Jefajers requested review from a team as code owners November 9, 2023 14:37
@daltondhcp daltondhcp merged commit a57b415 into Azure:main Nov 13, 2023
2 checks passed
@daltondhcp daltondhcp deleted the stack branch November 13, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants