Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(maestro): bump maestro to 15b3dcff1c9a96a02c516b787e847757dac8c1af #998

Merged
merged 1 commit into from
Dec 17, 2024
Merged

bump(maestro): bump maestro to 15b3dcff1c9a96a02c516b787e847757dac8c1af #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ clouds:
armHelperFPAPrincipalId: bc17c825-6cf8-40d0-8bd6-5536a993115e
# Maestro
maestro:
imageTag: bc2f131579c6ffc664c15f48c50a9936f1b4a7ce
imageTag: 15b3dcff1c9a96a02c516b787e847757dac8c1af
# Cluster Service
clusterService:
imageTag: 9f7fef3
Expand Down
2 changes: 1 addition & 1 deletion config/public-cloud-cs-pr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"private": false
},
"imageBase": "quay.io/redhat-user-workloads/maestro-rhtap-tenant/maestro/maestro",
"imageTag": "bc2f131579c6ffc664c15f48c50a9936f1b4a7ce",
"imageTag": "15b3dcff1c9a96a02c516b787e847757dac8c1af",
"postgres": {
"deploy": true,
"minTLSVersion": "TLSV1.2",
Expand Down
2 changes: 1 addition & 1 deletion config/public-cloud-dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"private": false
},
"imageBase": "quay.io/redhat-user-workloads/maestro-rhtap-tenant/maestro/maestro",
"imageTag": "bc2f131579c6ffc664c15f48c50a9936f1b4a7ce",
"imageTag": "15b3dcff1c9a96a02c516b787e847757dac8c1af",
"postgres": {
"deploy": true,
"minTLSVersion": "TLSV1.2",
Expand Down
2 changes: 1 addition & 1 deletion config/public-cloud-personal-dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"private": false
},
"imageBase": "quay.io/redhat-user-workloads/maestro-rhtap-tenant/maestro/maestro",
"imageTag": "bc2f131579c6ffc664c15f48c50a9936f1b4a7ce",
"imageTag": "15b3dcff1c9a96a02c516b787e847757dac8c1af",
"postgres": {
"deploy": false,
"minTLSVersion": "TLSV1.2",
Expand Down
3 changes: 2 additions & 1 deletion maestro/server/helm/templates/maestro.deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ spec:
- --db-user-file=/secrets/db/db.user
- --db-password-file=/secrets/db/db.password
- --db-name-file=/secrets/db/db.name
- --db-rootcert=
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value was file that didn't exist.
I am leaving this as empty so that the system root cert will be used.
See https://github.com/Azure/ARO-HCP/pull/998/files#r1888346094

- --db-sslmode={{ .Values.database.ssl }}
- --alsologtostderr
- -v={{ .Values.maestro.glog_v }}
Expand Down Expand Up @@ -88,7 +89,7 @@ spec:
- --db-user-file=/secrets/db/db.user
- --db-password-file=/secrets/db/db.password
- --db-name-file=/secrets/db/db.name
- --db-rootcert=/secrets/db/db.ca_cert
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file /secrets/db/db.ca_cert doesn't exist causing issue when the DB connection string is parsed.
Leaving this to empty will cause the system root cert to be used.

- --db-rootcert=
- --db-sslmode={{ .Values.database.ssl }}
- --db-max-open-connections={{ .Values.database.maxOpenConnections }}
- --message-broker-config-file=/secrets/maestro/config.yaml
Expand Down
Loading