Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onecert signer to SVC KV #1093

Merged
merged 3 commits into from
Jan 20, 2025
Merged

add onecert signer to SVC KV #1093

merged 3 commits into from
Jan 20, 2025

Conversation

geoberle
Copy link
Collaborator

What this PR does

  • provide cert officer permissions to devops MSI (so EV2 can act on the KV)
  • expose SVC KV url on svc-infra.bicep ...
  • ... so it can be consumed by the issuer setup set

Jira:
Link to demo recording:

Special notes for your reviewer

mociarain
mociarain previously approved these changes Jan 14, 2025
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once this is merged is there anything else to enable?

tony-schndr
tony-schndr previously approved these changes Jan 15, 2025
Copy link

Please rebase pull request.

* provide cert officer permissions to devops MSI (so EV2 can act on the KV)
* expose SVC KV url on svc-infra.bicep ...
* ... so it can be consumed by the issuer setup set

Signed-off-by: Gerd Oberlechner <[email protected]>
Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle geoberle merged commit 5e667ea into main Jan 20, 2025
22 checks passed
@geoberle geoberle deleted the svc-kv-cert-issuer branch January 20, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants