Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use MCR image for istio cert refresher pod #1069

Merged
merged 1 commit into from
Jan 9, 2025
Merged

use MCR image for istio cert refresher pod #1069

merged 1 commit into from
Jan 9, 2025

Conversation

geoberle
Copy link
Collaborator

@geoberle geoberle commented Jan 9, 2025 •
edited
Loading

What this PR does

  • use MCR image for istio cert refresher pod
  • use sleep infinity to prevent noise from a continously failing pod

Jira:
Link to demo recording:

Special notes for your reviewer

mociarain
mociarain approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice. Was there some issue with the standard busybox and Azure that meant we needed a special MSFT busybox?

@geoberle
Copy link
Collaborator Author

geoberle commented Jan 9, 2025

Oh nice. Was there some issue with the standard busybox and Azure that meant we needed a special MSFT busybox?

there was nothing technically wrong with it. but we should use only images from our private ACRs (and sync stuff into it if required) or from MCR.

@geoberle geoberle merged commit 21299d4 into main Jan 9, 2025
17 checks passed
@geoberle geoberle deleted the frontend-secret-refresher branch January 9, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mociarain mociarain mociarain approved these changes

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@mbarnes mbarnes Awaiting requested review from mbarnes mbarnes is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@venkateshsredhat venkateshsredhat Awaiting requested review from venkateshsredhat venkateshsredhat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoberle @mociarain