upgrade istio to 1.23 #1039
Merged
upgrade istio to 1.23 #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
requested review from
bennerv,
janboll,
weinong,
whober0521,
tony-schndr,
jmelis,
jonathan34c,
SudoBrendan and
UlrichSchlueter
as code owners
Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
istio-1-23-upgrade
branch
from
4e9d8b3 to
6f86da3
Compare
geoberle
commented
Jan 7, 2025
Comment on lines
+217
to
+219
| @scripts/aks-admin-access.sh $(SVC_RESOURCEGROUP) $(PRINCIPAL_ID) | ||
| @scripts/aks-kubeconfig.sh $(SVC_RESOURCEGROUP) $(AKS_NAME) "$(SVC_KUBECONFIG_FILE)" | ||
| @KUBEONFIG=$(SVC_KUBECONFIG_FILE) TARGET_VERSION=$(ISTIO_TARGET_VERSION) ISTIOCTL_VERSION=$(ISTIOCTL_VERSION) TAG=$(ISTIO_TAG) scripts/istio.sh |
There was a problem hiding this comment.
this is here just temporary. when we switch over to running svc-pipeline.yaml, the istio script is a dedicated post-step there.
janboll
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
AKS 1.31 requires istio >= 1.23
Jira:
Link to demo recording:
Special notes for your reviewer