Add Pipeline Run Script #1012
Merged
Add Pipeline Run Script #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janboll
requested review from
bennerv,
jharrington22,
SudoBrendan,
UlrichSchlueter and
zgalor
as code owners
janboll
force-pushed
the
add-pipeline-run
branch
2 times, most recently
from
4d94ea6 to
54d8403
Compare
geoberle
reviewed
Dec 20, 2024
janboll
requested review from
weinong,
whober0521 and
tony-schndr
as code owners
janboll
force-pushed
the
add-pipeline-run
branch
3 times, most recently
from
19c6c34 to
95e3147
Compare
janboll
force-pushed
the
add-pipeline-run
branch
12 times, most recently
from
c5195ff to
0213475
Compare
SudoBrendan
approved these changes
Jan 2, 2025
janboll
force-pushed
the
add-pipeline-run
branch
from
0213475 to
c874f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR switches frontline service deployments to use
templatizepipeline runs. It adds Makefile targets to run deployment and additionally, it adds dry run capabilities. Dry run is implemented using the helm diff plugin. In order to prevent credential leaking--suppress-secretsis set. Nevertheless, extra care should be taken when adopting this for other helm deployments to prevent secret leaking (looking at you cluster-service 😃 )Jira: https://issues.redhat.com/browse/ARO-13774
Link to demo recording:
Special notes for your reviewer