Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for dns zone #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

faraday23
Copy link

@faraday23 faraday23 commented May 24, 2021

current module assumes the resource group of the helm release issuer is in the same resource group as the AKS service.

this change adds support for dns zones that are in other resource groups

//as is it throws this error if a dns zone is in another resource group
Error presenting challenge: dns.RecordSetsClient

#CreateOrUpdate: Failure responding to request:
StatusCode=403 -- Original Error: autorest/azure: Service returned an error.
Status=403 Code="AuthorizationFailed"

@dutsmiller

@appkins
Copy link

appkins commented May 26, 2021

Might want to make the dns_resource_group_name optional and set it to resource_group_name if it's not set. We won't always want to specify a seperate rg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants