This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Updating templates for Voting Application #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be appended to the image name.
…store/linux Add linux sfmesh counter sf block store app
…Sample-2018-09-01-preview Add SF Volume Disk Counter Sample and template
…/service-fabric-mesh into 2018-09-01-preview
updated linux templates for visualobjects
* added windows version * fixed network and renamed * renamed network
* Move all updated templates to using 10.0.0.0/24 subnet. * Add default location value for all templates set to the resource group's location.
* added the stateful one * added the stateful one * fix the network address prefix * use secrets
…n the counter directory.
* Update mesh_rp.base.linux.json * Update mesh_rp.scaleout.linux.json * Update mesh_rp.upgrade.linux.json * Update mesh_rp.base.linux.json * Update mesh_rp.scaleout.linux.json * Update mesh_rp.upgrade.linux.json
KailasLokhande
changed the title
mattrowmsft
suggested changes
Nov 9, 2018
dkkapur
force-pushed
the
2018-09-01-preview
branch
from
db355e8 to
e04d008
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Current VotingApplication sample templates are not updated to latest scheme. This change is updating those along with isolated network and gateway.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Testing tests are same as existing sample, only difference would be using respective templates.
az login
az group create --name <> --location eastus
az mesh deployment create --resource-group <> --template-file <> --verbose
What to Check
Verify that the following are valid
Other Information