This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Add requirements for ADAL v3 and updated gateway endpoint to conform to PBI API v2 reqs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AcquireToken signature changed in v3 of the ADAL library. Now instead of a string for last parameter, it requires a Platform Parameter Object.
Neglegted to add the async changes as AcquireToken was deprecated in v3, replaced with AcquireTokenAsync.
AcquireToken signature changed in v3 of the ADAL library. Now instead of a string for last parameter, it requires a Platform Parameter Object.
AcquireToken signature changed in v3 of the ADAL library. Now instead of a string for last parameter, it requires a Platform Parameter Object.
AcquireToken signature changed in v3 of the ADAL library. Now instead of a string for last parameter, it requires a Platform Parameter Object. Made async changes as AcquireToken was deprecated in v3, replaced with AcquireTokenAsync.
AcquireToken signature changed in v3 of the ADAL library. Now instead of a string for last parameter, it requires a Platform Parameter Object. Made async changes as AcquireToken was deprecated in v3, replaced with AcquireTokenAsync.
BindToGateway Endpoint has changed and expects the gateway id. Added variables and serialization to handle this.
AcquireToken signature changed in v3 of the ADAL library. Now instead of a string for last parameter, it requires a Platform Parameter Object. Made async changes as AcquireToken was deprecated in v3, replaced with AcquireTokenAsync.
AcquireToken signature changed in v3 of the ADAL library. Now instead of a string for last parameter, it requires a Platform Parameter Object. Made async changes as AcquireToken was deprecated in v3, replaced with AcquireTokenAsync.
jacrys
changed the title
|
I've asked @mshmordo and @Alonbaram to review this before merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AcquireToken signature changed in v3 of the ADAL library. Now instead of a string for the final parameter, it requires a Platform Parameter Object. Made async changes as AcquireToken was deprecated in v3, replaced with AcquireTokenAsync. BindToGateway Endpoint has changed for takeover-dataset.ps1 and now expects the gateway id in POST body. Added variables and serialization to handle this.