Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to variable names due to Flexible Server #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raahmed
Copy link

@raahmed raahmed commented Jun 8, 2021

Adding:
SSL mode require.
Removing:
Full hostname.

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Adding:
SSL mode require.
Removing:
Full hostname.
'HOST': hostname + ".postgres.database.azure.com",
'USER': os.environ['DBUSER'] + "@" + hostname,
'PASSWORD': os.environ['DBPASS']
'HOST': os.environ['DBHOST'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raahmed Verify how the tutorial is written for this section. If we are stating to have DBHOST with severname and fully qualified name then we should revert back to 'HOST': hostname + ".postgres.database.azure.com" . Validate this with the tutorial please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of 'HOST' in the JSON output is the full name. To avoid confusion, I've changed the sample/tutorial so that it is a clear-cut copy-paste. Users get very confused and fail when they have to update the string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants