Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in error enum variant #157

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 23, 2024

No description provided.

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 23, 2024

CI failure looks like it should be a new issue

error: test failed, to rerun pass `--test test_view`

Caused by:
  process didn't exit successfully: `/home/runner/work/philips-isyntax-rs/philips-isyntax-rs/target/llvm-cov-target/debug/deps/test_view-80f4a159107b85ba` (signal: 11, SIGSEGV: invalid memory reference)

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 23, 2024

Created #158

@AzHicham
Copy link
Owner

Thank for your PR I'll try to relaunch the coverage test but the pr lgtm !!

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.02%. Comparing base (ccd85c4) to head (790673f).
Report is 40 commits behind head on develop.

Files with missing lines Patch % Lines
src/bindings.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
- Coverage    93.18%   91.02%   -2.17%     
===========================================
  Files            6        8       +2     
  Lines          396      568     +172     
===========================================
+ Hits           369      517     +148     
- Misses          27       51      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AzHicham AzHicham merged commit 3227604 into AzHicham:develop Sep 24, 2024
7 of 10 checks passed
AzHicham pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants