fix: missing include file

Az-r-ow · May 18, 2024 · 32f3a62 · 32f3a62
1 parent 09dd99d
commit 32f3a62
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/src/NeuralNet/callbacks/ModelCheckpoint.hpp b/src/NeuralNet/callbacks/ModelCheckpoint.hpp
@@ -67,7 +67,7 @@ class ModelCheckpoint : public Callback {
  private:
   std::string folderPath, filename;
   bool saveBestOnly, verbose;
-  double bestLoss = 10, bestAccuracy = 0;
+  double bestLoss = std::numeric_limits<double>::max(), bestAccuracy = 0;
   int numEpochs, bestEpoch;
   std::unordered_map<std::string, Logs> logs;
 

diff --git a/src/NeuralNet/losses/BCE.hpp b/src/NeuralNet/losses/BCE.hpp
@@ -1,6 +1,7 @@
 #pragma once
 
 #include "Loss.hpp"
+#include "utils/Functions.hpp"
 
 namespace NeuralNet {
 /**
@@ -9,7 +10,7 @@ namespace NeuralNet {
 class BCE : public Loss {
  public:
   static double cmpLoss(const Eigen::MatrixXd &o, const Eigen::MatrixXd &y) {
-    double threshold = 1.0e-5;
+    constexpr double threshold = 1.0e-5;
     Eigen::MatrixXd oTrim = trim(o, threshold);
     Eigen::MatrixXd yTrim = trim(y, threshold);
 
@@ -26,8 +27,9 @@ class BCE : public Loss {
 
   static Eigen::MatrixXd cmpLossGrad(const Eigen::MatrixXd &yHat,
                                      const Eigen::MatrixXd &y) {
+    constexpr double epsilon = 1.0e-9;
     return (yHat.array() - y.array()) /
-           ((yHat.array() * (1.0 - yHat.array())) + 1e-9);
+           ((yHat.array() * (1.0 - yHat.array())) + epsilon);
   }
 };
 

diff --git a/src/NeuralNet/utils/Functions.hpp b/src/NeuralNet/utils/Functions.hpp
@@ -135,7 +135,7 @@ inline std::string constructFilePath(const std::string &folderPath,
  *
  * @return The square of x
  */
-inline double sqr(const double x) { return x * x; };
+inline constexpr double sqr(const double x) { return x * x; };
 
 /* VECTOR OPERATIONS */
 

diff --git a/tests/test-functions.cpp b/tests/test-functions.cpp
@@ -29,8 +29,8 @@ TEST_CASE("vectorToMatrixXd outputs the correct format", "[helper_function]") {
 TEST_CASE("randomWeightInit initializes value properly",
           "[weight_initialization]") {
   Eigen::MatrixXd weights = Eigen::MatrixXd::Zero(5, 5);
-  double min = -2.0;
-  double max = 2.0;
+  constexpr double min = -2.0;
+  constexpr double max = 2.0;
 
   randomWeightInit(&weights, min, max);
   CHECK_MATRIX_VALUES_IN_RANGE(weights, min, max);
@@ -39,8 +39,8 @@ TEST_CASE("randomWeightInit initializes value properly",
 TEST_CASE("randomDistMatrixInit initializes values properly",
           "[weight_initialization]") {
   Eigen::MatrixXd weights = Eigen::MatrixXd::Zero(5, 5);
-  double mean = -1.0;
-  double stddev = 0;
+  constexpr double mean = -1.0;
+  constexpr double stddev = 0;
 
   randomDistMatrixInit(&weights, mean, stddev);