Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully handle malformed jwk headers #24

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

SalladinBalwer
Copy link
Member

Fixes an issue where parsing of a proof resulted in a panic if the jwk header was malformed. Now all parsing of the jwk header uses safe type assertions.

  • Fixes [Bug]: Panic on malformed jwk header #23

  • I have performed a self-review of my own code

  • I have verified that the code builds perfectly fine on my local system

  • I have added tests that prove my fix is effective or that my feature works

  • I have commented my code, particularly in hard-to-understand areas

  • I have verified that my code follows the style already available in the repository

  • I have made corresponding changes to the documentation

@SalladinBalwer SalladinBalwer self-assigned this Nov 21, 2024
@SalladinBalwer SalladinBalwer requested a review from a team as a code owner November 21, 2024 10:39
@SalladinBalwer SalladinBalwer linked an issue Nov 21, 2024 that may be closed by this pull request
1 task
@SalladinBalwer SalladinBalwer merged commit adf82c9 into main Nov 21, 2024
7 checks passed
@SalladinBalwer SalladinBalwer deleted the 23-bug-panic-on-malformed-jwk-header branch November 21, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Panic on malformed jwk header
2 participants