Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify wording on ParseOptions #16

Merged
merged 1 commit into from
Jan 23, 2024
Merged

docs: clarify wording on ParseOptions #16

merged 1 commit into from
Jan 23, 2024

Conversation

SalladinBalwer
Copy link
Member

Describe your changes

Clarify that TimeStamp and NonceHasTimestamp is used for checking clock-skew only.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@SalladinBalwer
chore: clarify wording on ParseOptions
aa6076c 
Clarify that `TimeStamp` and `NonceHasTimestamp` is used for checking clock-skew only.
@SalladinBalwer SalladinBalwer requested a review from a team as a code owner January 23, 2024 11:03
@SalladinBalwer SalladinBalwer linked an issue Jan 23, 2024 that may be closed by this pull request
[Bug]: Inconsistent use of TimeWindow #13
Closed
1 task
@SalladinBalwer SalladinBalwer merged commit 02ce260 into main Jan 23, 2024
6 checks passed
@SalladinBalwer SalladinBalwer deleted the 13-bug-inconsistent-use-of-timewindow branch January 23, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a354dpa a354dpa a354dpa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent use of TimeWindow
2 participants
@SalladinBalwer @a354dpa