feat!(cargo-acap-build): Make the release profile the default #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `cargo-acap-sdk` is the preferred tool for local development it should be relatively rare for people to use `cargo-acap-build` locally. As such it makes sense to optimize it for the continuous integration where I expect it will be used relatively frequently. This decision rests on the assumption that there are few cases when a developer would be better server by `cargo-acap-build` for local development compared to `cargo-acap-sdk build`.
guoxe
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
cargo-acap-sdkis the preferred tool for local development it should be relatively rare for people to usecargo-acap-buildlocally. As such it makes sense to optimize it for the continuous integration where I expect it will be used relatively frequently.This decision rests on the assumption that there are few cases when a developer would be better server by
cargo-acap-buildfor local development compared tocargo-acap-sdk build.Makefile:crates/cargo-acap-build/src/main.rs:cargo-acap-sdk.