Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Progressbar added & back-to-top button modified" #375

Merged

Conversation

Edasgh
Copy link
Contributor

@Edasgh Edasgh commented Oct 29, 2024

Closes: #353

  • Title : Design Eye-Catching Progress Bar and a Back to top button for UI Aesthetics
  • Name: Eshita Das
  • Idenitfy yourself: GSSOC & Hacktoberfest Contributor

Files Created:

  1. src/components/shared/Progressbar.jsx
  2. src/components/shared/Progressbar.css

Files Changed:

  1. src/App.jsx
  2. src/App.css
  3. src/components/shared/Navbar.jsx
  4. src/pages/About.jsx

Changes I made:

  1. Added a Progressbar component with gradient-color
  2. Added "handleScroll" function on "scroll" & "load" event on window
  3. Commented the code of the previous "scroll-to-top" button and added "ScrollToTop" button component from the "react-simple-scroll-up" library
  4. Defined styles in "App.css" to change the color of the "ScrollToTop" svg button on dark mode
  5. Removed the "progress" import from context in "App.jsx" cause it is of no use here
  6. Removed the invalid ; from the defined background color in "About.jsx"

Type of change ☑️

What sort of change have you made:

  • My code follows the code style of this project.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the code style of this project.
  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Demo Video :
https://www.loom.com/share/a33b909f7b1c417e92254c915e3dd946?sid=8704f85e-947c-4f88-9a13-4c26dd4710ee

Copy link

vercel bot commented Oct 29, 2024

@Edasgh is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Edasgh
Copy link
Contributor Author

Edasgh commented Oct 29, 2024

@Avdhesh-Varshney please check this PR

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:52am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@Avdhesh-Varshney Avdhesh-Varshney merged commit aef214b into Avdhesh-Varshney:main Oct 31, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors gssoc-ext gssoc extended 2024 hacktoberfest-accepted Hacktoberfest 2024 labels Oct 31, 2024
@Edasgh Edasgh deleted the progbar-back-to-top/353 branch October 31, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request gssoc-ext gssoc extended 2024 hacktoberfest-accepted Hacktoberfest 2024 level2 Intermediate level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Design Eye-Catching Progress Bar and a Back to top button for UI Aesthetics
2 participants