Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visitors count and github stars added : #311 done #339

Closed
wants to merge 6 commits into from

Conversation

VinayLodhi1712
Copy link
Contributor

@VinayLodhi1712 VinayLodhi1712 commented Oct 22, 2024

Closes: #311 done

  1. Added visitor count
  2. Add scroll top with it
  3. Added github star button with star showing.

Type of change β˜‘οΈ

What sort of change have you made:

  • [ x] New feature (non-breaking change which adds functionality)

Checklist: β˜‘οΈ

  • [x ] My code follows the Contributing Guidelines & Code of Conduct of this project.
  • [ x] This PR does not contain plagiarized content.
  • [ x] I have performed a self-review of my own code.
  • [ x] I have commented my code, particularly wherever it was hard to understand.
  • [ x] My changes generate no new warnings.

Screenshots πŸ“·

20241022163804.mp4

visitor3
visitor2

Note to reviewers πŸ“„

If you want to change style or you want to change it late you can go to the hitwebcounter website for help.

Copy link

vercel bot commented Oct 22, 2024

@VinayLodhi1712 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
chanakya βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 28, 2024 3:16pm

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a simple icon for visitors count

@Avdhesh-Varshney Avdhesh-Varshney added bug πŸ› Something isn't working Requested Changes βš™οΈ Some changes have been requested in this PR labels Oct 23, 2024
@VinayLodhi1712
Copy link
Contributor Author

@Avdhesh-Varshney sir i have changed something like that
again

actually the count is generated by an website and that generate an image for that number and we have this type of options
hitcounter

and i thing current one is looking good see above image or you can choose one of that website options.

@Avdhesh-Varshney
Copy link
Owner

okay, but it is not visible?
image

@VinayLodhi1712
Copy link
Contributor Author

it is visible at my device you should have wait for sometime i think if the issue persist than i will try again.

@VinayLodhi1712
Copy link
Contributor Author

VinayLodhi1712 commented Oct 24, 2024

@Avdhesh-Varshney after merge conflict solved it looks like -
commit

it is taking time until your website is loaded then it is showing the visitors number

@Avdhesh-Varshney can you plz see it and it is taking first time to show when it is first time loading only

@Avdhesh-Varshney
Copy link
Owner

It's not shown and I can't accept this cartoonify numbering for the website.

@VinayLodhi1712
Copy link
Contributor Author

VinayLodhi1712 commented Oct 28, 2024

@Avdhesh-Varshney can you plz send a video if possible that it is not showing as it is correctly working in my pc. on first time it is taking 10 sec at most then after it is showing . If it is not showing i would do once again by forking and make again changes and then i create a pull request and also i think this is the good looking visitors number.

visiting

and if you dont like this you can tell me which type of visitors show i can add .

@Avdhesh-Varshney
Copy link
Owner

image

After 1 minute, I've taked this ss

@VinayLodhi1712
Copy link
Contributor Author

ok @Avdhesh-Varshney i think i have to again work on this issue so i am working again and then creating a new pr for it.

@Avdhesh-Varshney Avdhesh-Varshney added invalid 🚫 This doesn't seem right wontfix ❌ This will not be worked on and removed Requested Changes βš™οΈ Some changes have been requested in this PR labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug πŸ› Something isn't working invalid 🚫 This doesn't seem right wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ§‘β€πŸ’»: Your visitor count and total stars not showing correctly on website.
2 participants