Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Navbar Issues: Dropdown, Navigation, and Dark Mode Alignment #327

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

AdityaP700
Copy link
Contributor

Closes: #303

  • Title :
  • Name: Aditya kumar Pattanayak
  • Idenitfy yourself: GSSOC-extd HackOctoberFest

In this pull request, I made several enhancements to the navbar component:

Fixed Dropdown Functionality: Resolved issues with the dropdown not opening when the "Resources" button is clicked.
Improved Navigation Links: Ensured that clicking on navbar links correctly navigates to their respective routes.
Adjusted Dark Mode Alignment: Aligned the dark mode toggle icon for consistent presentation across light and dark themes.
These changes aim to enhance the overall user experience and functionality of the navigation bar.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

bandicam.2024-10-21.20-57-11-411.mp4

Note to reviewers 📄

Well if any additional inputs you want to provide ,do let me know. Thanks in anticipation!!

Copy link

vercel bot commented Oct 21, 2024

@AdityaP700 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@AdityaP700
Copy link
Contributor Author

Hey @Avdhesh-Varshney ,well the changes has been done with respect to the issue #303 . Well waiting for any additional inputs . Thanks in anticipation !!1

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 5:08am

@Avdhesh-Varshney Avdhesh-Varshney merged commit 44819e6 into Avdhesh-Varshney:main Oct 22, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors gssoc-ext gssoc extended 2024 hacktoberfest-accepted Hacktoberfest 2024 labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request gssoc-ext gssoc extended 2024 hacktoberfest-accepted Hacktoberfest 2024 level2 Intermediate level issues/pull requests
Projects
None yet
3 participants