Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed floaty footer #318

Closed
wants to merge 2 commits into from
Closed

fixed floaty footer #318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99a896b
fixed floaty footer
Oct 20, 2024
2930b2f
requested changes fixed
Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@ function App() {
}, [isDarkMode]);

return (
<div className={`d-flex flex-column ${isDarkMode ? 'dark' : ''}`}>
<Router>
<div id="parentLayout" className={`d-flex flex-column ${isDarkMode ? 'dark' : ''}`}>
<LoadingBar height={3} color="#f11946" progress={progress} />
<Router>
<Navbar />
<LoadingBar height={3} color="#f11946" progress={progress} />
omkar861856 marked this conversation as resolved.
Show resolved Hide resolved

<main className="container flex-grow-1 mt-4">
<Routes>
<Route exact path="/" element={<Home />} />
Expand All @@ -55,7 +54,6 @@ function App() {
<Route exact path="/auth/signup" element={<SignUp />} />
</Routes>
</main>

<Footer />
</Router>
</div>
Expand Down
12 changes: 12 additions & 0 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
box-sizing: border-box;
}

html, body, #root, #parentLayout{
height: 100vh;
width: 100vw;
}

body {
background-color: rgba(228, 193, 129, 0.272);
}
Expand All @@ -12,4 +17,11 @@ body {
background-color: #2c2a2a;
color: white;
transition: 0.25s;
}

/* layout */

#parentLayout{
display: grid;
grid-template-rows: auto 1fr auto;
}