Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light mode #254

Merged
merged 5 commits into from
Aug 10, 2024
Merged

Dark/Light mode #254

merged 5 commits into from
Aug 10, 2024

Conversation

sharmi4590
Copy link
Contributor

Closes: issue #245

  • Title : Dark/Light mode is not applicable to whole page
  • Name: Bheemisetty Sharmila
  • Idenitfy yourself: GSSOC

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
Initially the Dark/Light mode was only applicable on the navbar and footer now I have made it for the Home page as well as the about page.

Type of change ☑️

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot (665)
Screenshot (666)
Screenshot (667)
Screenshot (668)

Note to reviewers 📄

Copy link

vercel bot commented Jul 30, 2024

@sharmi4590 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 11:22am

@Avdhesh-Varshney
Copy link
Owner

Apply it not only on component upto about, but on overall website.

@sharmi4590
Copy link
Contributor Author

Done .
Screenshot (683)
Screenshot (684)
Screenshot (685)
Screenshot (686)

@sharmi4590
Copy link
Contributor Author

@Avdhesh-Varshney Please check the PR

@Avdhesh-Varshney
Copy link
Owner

Don't delete the carousel or any other part

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Aug 6, 2024
@sharmi4590
Copy link
Contributor Author

Don't delete the carousel or any other part

I haven't deleted anything could you please tell me which part i removed specifically?

@Avdhesh-Varshney
Copy link
Owner

Don't delete the carousel or any other part

I haven't deleted anything could you please tell me which part i removed specifically?

image

@sharmi4590
Copy link
Contributor Author

Done , due to merging of other PRs it got deleted nd now it has been cleared. @Avdhesh-Varshney please check once
Screenshot (689)

@sharmi4590
Copy link
Contributor Author

Hey @Avdhesh-Varshney could u please merge it fast as today is the last date that too evening

@Avdhesh-Varshney Avdhesh-Varshney linked an issue Aug 10, 2024 that may be closed by this pull request
@Avdhesh-Varshney Avdhesh-Varshney merged commit 2a3633b into Avdhesh-Varshney:main Aug 10, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request gssoc These issue/pull request will be considered for GSSOC'24 and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Aug 10, 2024
@Avdhesh-Varshney Avdhesh-Varshney added level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request gssoc These issue/pull request will be considered for GSSOC'24 level2 Intermediate level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛: Dark/Light mode is not applicable to whole page
2 participants