Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added favicon #235

Closed
wants to merge 3 commits into from
Closed

Conversation

Maana-Ajmera
Copy link
Contributor

Closes #228

  • Title : Favicon
  • Name: : Maana Ajmera
  • Idenitfy yourself: GSSOC

Describe the add-ons or changes you've made 📃

I have added the favicon to the website which adds a good look to it

Type of change ☑️

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image

Copy link

vercel bot commented Jul 12, 2024

@Maana-Ajmera is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 5:35am

favicon.png Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert it into ico format

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And keep this image in circular cropping

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jul 14, 2024
@Maana-Ajmera
Copy link
Contributor Author

image

@Avdhesh-Varshney done

@Maana-Ajmera
Copy link
Contributor Author

@Avdhesh-Varshney I have resolved conflicts and done the changes , please review my PR and if there is anything else that needs to be changes , please let me know

@Avdhesh-Varshney
Copy link
Owner

@Maana-Ajmera it is resolved.

@Avdhesh-Varshney Avdhesh-Varshney added the wontfix ❌ This will not be worked on label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: [Enhancement] : Adding favicon in website
2 participants