Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add social icon in footer #227

Closed

Conversation

ANKeshri
Copy link

Closes: #219

  • Title : Add social icons with hover effect in footer of all pages .
  • Name: Aditya Narayan
  • Idenitfy yourself: GSSOC

Describe the add-ons or changes you've made 📃

Add social icons with hover effect in footer as shown in video .

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

BEFORE :

Screenshot 2024-07-11 230949

AFTER :

Recording.2024-07-11.230913.mp4

Copy link

vercel bot commented Jul 11, 2024

@ANKeshri is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@ANKeshri
Copy link
Author

@Avdhesh-Varshney please review once and merge my pr and if possible please update level .
Thank you , Excited to work more on this project .

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 2:34pm

@Avdhesh-Varshney
Copy link
Owner

enlist them in a list format

image

@Avdhesh-Varshney Avdhesh-Varshney added the Requested Changes ⚙️ Some changes have been requested in this PR label Jul 12, 2024
@ANKeshri
Copy link
Author

ANKeshri commented Jul 12, 2024

@Avdhesh-Varshney done the required changes

image

@Avdhesh-Varshney
Copy link
Owner

No, I've told you to create a stack of contacts. Remove icons, just give the text as shown of resources section.

@ANKeshri
Copy link
Author

No, I've told you to create a stack of contacts. Remove icons, just give the text as shown of resources section.

ok sure i got it now

@ANKeshri
Copy link
Author

Screenshot 2024-07-14 141222

@ANKeshri
Copy link
Author

@Avdhesh-Varshney please review once and merge my pr

@Avdhesh-Varshney
Copy link
Owner

re-raise the pr. It can't be merged and replace facebook url with discord url and twitter url with youtube ok and add react-icons in front of the names.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working wontfix ❌ This will not be worked on and removed Requested Changes ⚙️ Some changes have been requested in this PR labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: want to add social icons in footer and give hover effect
2 participants