-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created an about page. #151
Conversation
@aapJoysakoi is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aapJoysakoi Looks Great. I'm thinking to keep the css files apart from the project structure. So, create css
named folder aside pages
or just inside src
. Then keep your About.css
file iniit.
hey, I made the requested changes. please have a look at it and let me know if any other modifications are required. I've currently added only about.css file in the separate folder in src.. I think that's what you meant (or to add all the css files in that folder?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great !! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aapJoysakoi PR Approved 🎉
Closes: #91
Describe the add-ons or changes you've made 📃
-created an about page which displays image of and info. about Aacharya Chanakya.
Type of change ☑️
Checklist: ☑️
Screenshots 📷
Note to reviewers 📄