Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created an about page. #151

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

aapJoysakoi
Copy link
Contributor

@aapJoysakoi aapJoysakoi commented Jun 24, 2024

Closes: #91

  • Title : created an about page
  • Name: Joysa Kaushik
  • Role: SSOC

Describe the add-ons or changes you've made 📃

-created an about page which displays image of and info. about Aacharya Chanakya.

Type of change ☑️

  • My code follows the code style of this project
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image

image

Note to reviewers 📄

Copy link

vercel bot commented Jun 24, 2024

@aapJoysakoi is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 10:42am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aapJoysakoi Looks Great. I'm thinking to keep the css files apart from the project structure. So, create css named folder aside pages or just inside src. Then keep your About.css file iniit.

@Avdhesh-Varshney Avdhesh-Varshney added the Requested Changes ⚙️ Some changes have been requested in this PR label Jun 24, 2024
@aapJoysakoi
Copy link
Contributor Author

hey, I made the requested changes. please have a look at it and let me know if any other modifications are required. I've currently added only about.css file in the separate folder in src.. I think that's what you meant (or to add all the css files in that folder?)

Copy link

@kushagra-singhh kushagra-singhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great !! ✨

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aapJoysakoi PR Approved 🎉

@Avdhesh-Varshney Avdhesh-Varshney linked an issue Jun 25, 2024 that may be closed by this pull request
@Avdhesh-Varshney Avdhesh-Varshney merged commit a3e14b1 into Avdhesh-Varshney:main Jun 25, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request Approved ✔️ This PR is approved by the PR or, Mentors Advanced Advanced level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24 and removed Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Advanced Advanced level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request SSOC These issue/pull request will be considered for SSOC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Chanakya.
3 participants