Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update .gitignore to ignore virtual environment folder #84

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

ChiragAgg5k
Copy link
Contributor

Closes: #83

  • Title : update .gitignore to ignore virtual environment folder
  • Name: Chirag Aggarwal
  • Idenitfy yourself: SSOC contributor

Describe the add-ons or changes you've made 📃

updated .gitignore to ignore virtual environment folder

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChiragAgg5k don't update the gitignore. But update the readme file.

@ChiragAgg5k
Copy link
Contributor Author

Changed .gitignore back to original and updated readme. Please consider squash merge. Thanks

@Avdhesh-Varshney Avdhesh-Varshney merged commit d15d0df into Avdhesh-Varshney:main Jul 2, 2024
@Avdhesh-Varshney Avdhesh-Varshney added documentation 📃 Improvements or additions to documentation enhancement 🧑‍💻 New feature or request BEGINNER SSOC Status: Approved and removed bug 🐛 Something isn't working Status: Requested Changes labels Jul 2, 2024
@ChiragAgg5k ChiragAgg5k deleted the refactor branch July 2, 2024 15:40
imDarshanGK pushed a commit to imDarshanGK/Jarvis that referenced this pull request Nov 8, 2024
chore: update .gitignore to ignore virtual environment folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEGINNER documentation 📃 Improvements or additions to documentation enhancement 🧑‍💻 New feature or request SSOC Status: Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Small issue regarding naming convention for the virtual environment
2 participants