Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Diabetes test under Healthcare Programs and resolved the greetings bug on login #35

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ChiragGupta16
Copy link
Contributor

Closes: Issue #34

  • Title : Adding a diabetes test feature using DL models and resolved the greetings bug on login
  • Name: : Chirag Gupta
  • Idenitfy yourself: : Participant in SSoC

Describe the add-ons or changes you've made 📃

Firstly I inserted a new option under Service dropdown named "Healthcare Programs".
Then I inserted a option named "Diabetes Test" under it.
For implementing it, I trained a model which I saved in ".keras" format and uploaded it in a new folder "dlModels" under models folder.
The main code lies in the "source\features\healthcarePrograms\diabetes_test.py" where I created functions containing the form to be filled by the user, loading the model and returning the test result.
I imported these functions in "main.py" and implemented it in a short & neat manner using "if statements".

During testing, I found a bug which greeted me every time when I change options, so I fixed the issue by adding a few statements it in "mains.py". Added a comment line before the new greetings code.

Before making the modifications, I gone through whole code and contributed in the same style of the project maintaining the project layout and all new created variables in "main.py" are named after diabetes test to avoid conflicts in future. Also the number of new variables are kept to minimum.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I logged in using SuperAdmin, Admin, user and also a created a new ID to test out the features.
After login, the greetings were given only once.
On selecting the "Diabetes Test" from dropdown, a form appears in which I submitted the validation data of the model.
The correct results were shown in the desired manner.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Service and Program
The userName, service type and Program

Form
Diabetes Test Form

Result for an example test
Example Result

Note to reviewers 📄

I created a new Service for Healthcare because I did not find Diabetes Test fit among Basic Programs. Moreover, I intend to contribute more in Healthcare section.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChiragGupta16 PR Approved 🎉

@Avdhesh-Varshney Avdhesh-Varshney linked an issue Jun 26, 2024 that may be closed by this pull request
@Avdhesh-Varshney Avdhesh-Varshney merged commit cd4d332 into Avdhesh-Varshney:main Jun 26, 2024
1 check passed
@Avdhesh-Varshney
Copy link
Owner

@ChiragGupta16 But always raise the pr by creating your own seprate branch never commit in main branch

imDarshanGK pushed a commit to imDarshanGK/Jarvis that referenced this pull request Nov 8, 2024
Added Diabetes test under Healthcare Programs and resolved the greetings bug on login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Adding a diabetes test feature using DL model
2 participants