Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live location and weather detection # 238 using branch #245

Closed
wants to merge 1 commit into from

Conversation

Nayan2003
Copy link

@Nayan2003 Nayan2003 commented Dec 15, 2024

Closes: #238
384125499-7d53ca9e-7136-445d-b79b-7a463a8beeb8

  • Title: Add live location and weather detection
  • Your Name: Nayan Khuje

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Working Video 📷

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Avdhesh-Varshney
Copy link
Owner

@Nayan2003 Also consider the last 2 points, #239 (review)
For your reference, consider the earlier merged prs.

@Nayan2003 Nayan2003 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: upgrade live location detection and weather detection
2 participants