Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictionary.py #232

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

shrehs
Copy link
Contributor

@shrehs shrehs commented Nov 5, 2024

Closes: #218

  • Title: Completion of dictionary.py file
  • Your Name: Shreya H S
  • Idenitfy yourself: GSSOC'24-Ext

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
Since pydictionary is outdated and relies on goslate (which is problematic), you might want to switch to another dictionary library, such as PyMultiDictionary, which are more compatible with Python 3.
pdated Dictionary Calls: Use .meanings(), .synonyms(), and .antonyms() methods instead of directly accessing properties.
Result Handling: Check if a result is returned and provide a warning if no result is found.
Error Handling: Added exception handling to manage any unexpected issues gracefully.

Give a clear description of what have you added or modifications made
The error you're seeing occurs because pydictionary relies on the goslate package, which in turn depends on the outdated futures library. The futures library is only compatible with Python 2 and causes syntax errors in Python 3 environments. Hence used PyMultiDictionary.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

dictionary.webm

Screenshot (146)
Screenshot (147)
Screenshot (148)

Copy link

github-actions bot commented Nov 5, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Avdhesh-Varshney Avdhesh-Varshney merged commit 74356ec into Avdhesh-Varshney:main Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Completion on dictionary.py
2 participants