Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#171 Intro #214

Merged
merged 7 commits into from
Oct 31, 2024
Merged

#171 Intro #214

merged 7 commits into from
Oct 31, 2024

Conversation

AnushkaS77
Copy link
Contributor

@AnushkaS77 AnushkaS77 commented Oct 31, 2024 •
edited
Loading

  • Title: intro at begining
  • Your Name: AnushkaS77
  • Idenitfy yourself: gssoc contributer

Describe the add-ons or changes you've made 📃

made changes in home.py
added intro.gif file to assests

Checklist: ☑️

  • [x ] My code follows the Contributing Guidelines & Code of Conduct of this project.
  • [x ] This PR does not contain plagiarized content.
  • [x ] I have performed a self-review of my own code.
  • [ x] I have commented my code, particularly wherever it was hard to understand.

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@AnushkaS77
Copy link
Contributor Author

home.webm

Avdhesh-Varshney
Avdhesh-Varshney requested changes Oct 31, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these changes, I'm providing the solution

.streamlit/secrets.example.toml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@Avdhesh-Varshney
Copy link
Owner

Avdhesh-Varshney commented Oct 31, 2024 •
edited
Loading

Also move your intro video in assets folder. It's better to convert your video into gif format

@AnushkaS77
Copy link
Contributor Author

@Avdhesh-Varshney if the file is in gif form ...it gets stuck
image

@AnushkaS77
Copy link
Contributor Author

@Avdhesh-Varshney ive done the changes you asked me to

@Avdhesh-Varshney Avdhesh-Varshney linked an issue Oct 31, 2024 that may be closed by this pull request
add intro animation at the start #171
Closed
@Zedoman Zedoman merged commit d32a9a3 into Avdhesh-Varshney:main Oct 31, 2024
imDarshanGK pushed a commit to imDarshanGK/Jarvis that referenced this pull request Nov 8, 2024
@Zedoman
Merge pull request Avdhesh-Varshney#214 from AnushkaS77/intro
ad96d00 
Avdhesh-Varshney#171 Intro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avdhesh-Varshney Avdhesh-Varshney Avdhesh-Varshney approved these changes

@Zedoman Zedoman Zedoman approved these changes

Assignees

@AnushkaS77 AnushkaS77

Labels
enhancement 🧑‍💻 New feature or request gssoc-ext hacktoberfest-accepted level2 Status: Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add intro animation at the start
3 participants
@AnushkaS77 @Avdhesh-Varshney @Zedoman