Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance mylocation under simple programs #197

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

nidhi2026
Copy link

Closes: #196

  • Title: Fix and enhance my location under simple programs
  • Your Name: Nidhi
  • Idenitfy yourself: GSSOC-ext Contributor

Describe the add-ons or changes you've made 📃

  • I added value handling if an attribute is not fetched from API to avoid any error as in the mentioned issue.
  • Additionally, I added a DNS pointer if found for that IP
  • Continent code
  • The organization under which that IP is registered.
  • Accuracy of location of IP in km

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image
Here is a preview of working after changes were made,

ip.-.Made.with.Clipchamp.mp4

Note: I didn't use my IP, just used some random to show the structure of the result.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Zedoman Zedoman merged commit 54ad23c into Avdhesh-Varshney:main Oct 23, 2024
1 check passed
imDarshanGK pushed a commit to imDarshanGK/Jarvis that referenced this pull request Nov 8, 2024
Fix and enhance mylocation under simple programs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛: My Location throw error when associated city, region not found
4 participants