RecipeFinder #195
Merged
RecipeFinder #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
|
Provide a video for the changes u have done |
recipeFinder2.webm |
I have attached in the previous comment and also please assign me to the new issue I have raised #198 . |
Zedoman
previously approved these changes
Oct 23, 2024
Avdhesh-Varshney
approved these changes
Oct 23, 2024
|
Never commit directly in main branch |
Sure, I'll remember that! |
Zedoman
approved these changes
Oct 23, 2024
imDarshanGK
pushed a commit
to imDarshanGK/Jarvis
that referenced
this pull request
Nov 8, 2024
RecipeFinder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #72
Describe the add-ons or changes you've made 📃
Made changes on function as it's dynamically called which had caused issues in input acceptance
Give a clear description of what have you added or modifications made
modified function name to resolve dynamic calling of the function as it would have accepted null as input
Added a button "Find Recipe"
Checklist: ☑️
Screenshots 📷
Uploading recipeFinder2.webm…