Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-anime-in-api-programs #190

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

nidhi2026
Copy link

Closes: #188

  • Title: Add anime in api programs
  • Your Name: Nidhi
  • Idenitfy yourself: GSSOC-ext Contributor

Describe the add-ons or changes you've made 📃

Added an anime under API programs

  • Top 10 animes
  • Top 10 characters on MyAnimeList site
  • Filter animes on the basis of order(rank/fav/popularity/etc), sort(asc/desc) and multiple genre select

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Zedoman
Copy link
Contributor

Zedoman commented Oct 19, 2024

Provide a working video of the project @nidhi2026

@nidhi2026
Copy link
Author

Here is a demo:

jarvisanime.-.Made.with.Clipchamp.2.mp4

@nidhi2026
Copy link
Author

@Zedoman I have attached a preview

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Zedoman Zedoman merged commit 35f47ec into Avdhesh-Varshney:main Oct 20, 2024
1 check passed
imDarshanGK pushed a commit to imDarshanGK/Jarvis that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Adding anime API under API programs with filtering for genres, release year, search, trending etc
4 participants