Recipe_finder addition #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
Avdhesh-Varshney
requested changes
Oct 7, 2024
|
|
||
| # Function to fetch recipes | ||
| def fetch_recipes(query): | ||
| api_key = os.getenv('SPOONACULAR_API_KEY') # Retrieve API key from environment variable |
There was a problem hiding this comment.
Use streamlit secrets to store these environment variables. Don't use os.getenv.
There was a problem hiding this comment.
I'll do the required changes and get back to you.
There was a problem hiding this comment.
Hey,
Hope this finds you well. I have opened #172 PR for the First Review requested changes. Please do let me know if it requires further changes. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #72
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
Flexbox Layout: Implemented a flexbox layout to organize the recipe items in a responsive manner. Each recipe item is displayed in a flexible container, allowing for better alignment and spacing without altering the size or shape of the elements.
Clickable Recipe Items: Modified the recipe item layout so that the entire item is clickable, not just the title. This enhances user experience by making it easier to navigate to the recipe details.
Title Style Adjustments: Removed the default blue color and underline from the recipe title links on hover, ensuring a cleaner appearance that matches your design preferences. This was achieved by adding specific CSS styles.
Input Placeholder Text: Added placeholder text inside the input box to guide users on what to enter (e.g., “Enter ingredients or dish name”), which disappears when the user clicks on the input field.
Title and more formating: Adjusted the font size of the recipe titles for better readability, making them more prominent without changing their color or style drastically.
Git Ignore File: Guided on creating a .gitignore file to prevent sensitive information, such as API keys, virtual enve from being pushed to the repository.
Checklist: ☑️
Screenshots 📷