Improved consistency with custom model data arg parser

Auxilor · Jul 21, 2024 · 7cf2fa4 · 7cf2fa4
1 parent cbf88ce
commit 7cf2fa4
Showing 1 changed file with 6 additions and 14 deletions.
diff --git a/...re/core-backend/src/main/kotlin/com/willfp/eco/internal/items/ArgParserCustomModelData.kt b/...re/core-backend/src/main/kotlin/com/willfp/eco/internal/items/ArgParserCustomModelData.kt
@@ -7,20 +7,12 @@ import java.util.function.Predicate
 
 object ArgParserCustomModelData : LookupArgParser {
     override fun parseArguments(args: Array<out String>, meta: ItemMeta): Predicate<ItemStack>? {
-        var modelData: Int? = null
+        val arg = args.firstOrNull {
+            it.startsWith("custom-model-data:", ignoreCase = true)
+                    || it.startsWith("custom_model_data:", ignoreCase = true)
+        } ?: return null
 
-        for (arg in args) {
-            val argSplit = arg.split(":")
-            if (!argSplit[0].equals("custom-model-data", ignoreCase = true)) {
-                continue
-            }
-            if (argSplit.size < 2) {
-                continue
-            }
-            modelData = argSplit[1].toIntOrNull()
-        }
-
-        modelData ?: return null
+        val modelData = arg.split(":")[1].toIntOrNull() ?: return null
 
         meta.setCustomModelData(modelData)
 
@@ -40,6 +32,6 @@ object ArgParserCustomModelData : LookupArgParser {
             return null
         }
 
-        return "custom-model-data:${meta.customModelData}"
+        return "custom_model_data:${meta.customModelData}"
     }
 }