-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites Dashboard: Update action's isEligible
checks to exclude Jetpack/P2 sites from the action options
#96803
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~427 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
…from the action options
60e2574
to
b62f816
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
isEligible
checks to exclude Jetpack/P2 sites from the action options
This required creating the site via pressable and deactivating Jetpack + Jetpack protect while still having the A4A client plugin installed (the a4a client plugin maintains a Jetpack connection irrc). All the hosting options are hidden, only open/wpadmin/move links are present: |
Fixes https://github.com/Automattic/dotcom-forge/issues/9971
Proposed Changes
The Jetpack action items were lost when merging https://github.com/Automattic/wp-calypso/pull/94238/files?w=1#diff-173bec7d847197dc6a90c47661016102ba95728dab618e17b774c11c7ed1994cL550-L565, this PR adds these actions and the migration related ones back into the list. It also hides the wpcom site actions that aren't relevant to Jetpack/p2 sites.
Testing Instructions
sites-dataviews-actions.test.ts
).