Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain transfer: Fix CTA button color #79692

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Domain transfer: Fix CTA button color #79692

merged 1 commit into from
Jul 20, 2023

Conversation

renancarvalho
Copy link
Contributor

@renancarvalho renancarvalho commented Jul 20, 2023 •
edited
Loading

Proposed Changes

Fix the button color and unify the same style on buttons no step 1 and 2.
Context p9Jlb4-8kT-p2#comment-8667

image

Testing Instructions

  • Pull and run this branch or use live link
  • Navigate to /setup/domain-transfer and check if the buttons match the design

@renancarvalho renancarvalho requested a review from a team July 20, 2023 15:13
@renancarvalho renancarvalho self-assigned this Jul 20, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 20, 2023
@github-actions
Copy link

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-0bed5b78c2e126aac2a8b9517b386f87f8aae9c3
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-0bed5b78c2e126aac2a8b9517b386f87f8aae9c3&env=jetpack

escapemanuele
escapemanuele approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

agrullon95
agrullon95 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@agrullon95 agrullon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well. The buttons on both screens are matching.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@renancarvalho renancarvalho merged commit a90f332 into trunk Jul 20, 2023
@renancarvalho renancarvalho deleted the fix_button_color branch July 20, 2023 17:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 20, 2023
@mtias
Copy link
Member

mtias commented Jul 20, 2023

This is not great. We should be using the variant="primary" and ensuring that renders as needed for these contexts. Can we revert?

@alshakero
Copy link
Member

@mtias I agree, sending a follow up shortly.

@alshakero alshakero mentioned this pull request Jul 20, 2023
Closed
@alshakero
Copy link
Member

alshakero commented Jul 20, 2023 •
edited
Loading

@mtias is this better? I'm not sure about the disabled state.

@agrullon95 agrullon95 mentioned this pull request Jul 20, 2023
Merged
@paulopmt1 paulopmt1 mentioned this pull request Jul 25, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escapemanuele escapemanuele escapemanuele approved these changes

@agrullon95 agrullon95 agrullon95 approved these changes

Assignees

@renancarvalho renancarvalho

Labels
Stepper
Projects
Vertex Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@renancarvalho @matticbot @mtias @alshakero @agrullon95 @escapemanuele