Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Migrate apps unit tests away from wp scripts" #79159

Merged

Conversation

roo2
Copy link
Contributor

@roo2 roo2 commented Jul 10, 2023

Reverts #79097

This caused the newspack-blocks sync task to fail to replace the text domain. Details: p1688956741274269/1685923446.140549-slack-C7YPUHBB2

@roo2 roo2 requested a review from a team July 10, 2023 02:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 10, 2023
@github-actions
Copy link

github-actions bot commented Jul 10, 2023

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit revert-79097-migrate-apps-unit-tests-away-from-wp-scripts on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@roo2 roo2 merged commit 126fb96 into trunk Jul 10, 2023
@roo2 roo2 deleted the revert-79097-migrate-apps-unit-tests-away-from-wp-scripts branch July 10, 2023 02:59
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 10, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~948 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
site-setup-flow               +621 B  (+0.0%)     +948 B  (+0.2%)
plugins                       +621 B  (+0.0%)     +948 B  (+0.2%)
media                         +621 B  (+0.0%)     +948 B  (+0.2%)
import-hosted-site-flow       +621 B  (+0.0%)     +948 B  (+0.2%)
import-flow                   +621 B  (+0.0%)     +948 B  (+0.1%)
devdocs                       +621 B  (+0.3%)     +948 B  (+1.6%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~948 bytes added 📈 [gzipped])

name                                               parsed_size           gzip_size
async-load-calypso-post-editor-media-modal              +621 B  (+0.0%)     +948 B  (+0.3%)
async-load-calypso-post-editor-editor-media-modal       +621 B  (+0.0%)     +948 B  (+0.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants