Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Add TT2 to design picker #60504

Merged
merged 1 commit into from
Jan 26, 2022
Merged

FSE: Add TT2 to design picker #60504

merged 1 commit into from
Jan 26, 2022

Conversation

zaguiini
Copy link
Contributor

Closes #58663.

Changes proposed in this Pull Request

We're finally adding TT2 to the design picker on FSE site creation flows! 🎉

Testing instructions

Sandbox yourself.

  • Create a site through Gutenboarding (/new).

You should be able to pick Twenty Twenty-Two from the Design Picker.

  • Create a site through onboarding (/start)

You should be able to pick Twenty Twenty-Two from the Design Picker.

Screenshots

Gutenboarding /new Onboarding /start
image image

@zaguiini zaguiini added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Full Site Editing labels Jan 26, 2022
@zaguiini zaguiini requested review from simison and a team January 26, 2022 19:13
@zaguiini zaguiini self-assigned this Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Jan 26, 2022

@matticbot
Copy link
Contributor

matticbot commented Jan 26, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~162 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding      +1485 B  (+0.1%)     +162 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~112 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
signup               +1485 B  (+0.3%)     +112 B  (+0.2%)
jetpack-connect      +1485 B  (+0.2%)     +112 B  (+0.0%)
accept-invite        +1485 B  (+0.5%)     +112 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@zaguiini zaguiini force-pushed the add/tt2-to-design-picker branch from 2897a26 to f7978be Compare January 26, 2022 21:13
@zaguiini zaguiini merged commit e6ebb8f into trunk Jan 26, 2022
@zaguiini zaguiini deleted the add/tt2-to-design-picker branch January 26, 2022 22:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSE Beta: Add themes to Design step in onboarding
3 participants