Update @wordpress/components type definitions to 14.0.9

[sirbrillig]

Changes proposed in this Pull Request

This updates our dependency on the @wordpress/components type definitions (this is actually @types/wordpress__components since it uses DefinitelyTyped, not the package itself) to 14.0.9 which includes the types for ComboboxControl, ToolbarGroup, Guide, Tip and VisuallyHidden thanks to the following PRs:

• Add Tip and VisuallyHidden to @wordpress/components DefinitelyTyped/DefinitelyTyped#58058
• Add Guide to @wordpress/components DefinitelyTyped/DefinitelyTyped#58077
• Add ToolbarGroup to @wordpress/components DefinitelyTyped/DefinitelyTyped#58080
• Add types for ComboboxControl to @wordpress/components DefinitelyTyped/DefinitelyTyped#58106

Since we use all of the above components in calypso, this will fix our remaining TypeScript errors.

Note: the editing-toolkit app uses the Tip component, which works in TypeScript because that package adds its own type definition. Because this PR also adds a (more correct) type definition, it creates a type error in that package. It also creates an additional type error because that package is using Tip with a size prop that doesn't exist in the component's definition. Therefore, this PR removes both the override and the use of size.

Testing instructions

Verify that this doesn't change any behavior and affects only types.

[github-actions]

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-24561
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-24561&env=jetpack

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/wordpress-components-type-definitions-to-14-0-9 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

[sirbrillig]

The failing build reads:

  Yarn error YN0002: @types/wordpress__components@npm:14.0.9 doesn't provide react (p0930a), requested by downshift
  Yarn error YN0068: @types/wordpress__components ➤ peerDependencies ➤ react: No matching package in the dependency tree; you may not need this rule anymore.

...which is weird because none of the changes between @types/wordpress__components 14.0.5 and 14.0.9 should have touched CustomSelectControl and its dependency on downshift. 🤔

Also, those seem to be warnings and not errors so I'm not sure why they become errors at the bottom.

[tyxla]

I'm assuming that WordPress/gutenberg#37578 fixed this, so if we upgrade the version of @wordpress/components we use in Calypso, the issue should get resolved. Haven't tested, though.

[sirbrillig]

Interesting! Good find. However, it looks like we're already using the latest version, 19.2.0:

wp-calypso/package.json

Line 181 in a1b9043

"@wordpress/components": "^19.2.0",

(and presumably that version includes the fix you linked to since the fix was merged 15 days ago and 19.2 was released 9 days ago).

[tyxla]

Ah. Yep, so I guess we need another DT PR then 😉

[sirbrillig]

🤔 I was about to do that, but then I looked and apparently no other DT types use peerDependencies, which seems concerning. I also found DefinitelyTyped/DefinitelyTyped#56011 and DefinitelyTyped/DefinitelyTyped#20290 which imply that they're not supported.

[tyxla]

I see. In that case, we can specify the peer dependency as an exception in yarn's packageExtensions. It was already done FWIW, so I just updated the version in ff90d70. That should do the job.

[tyxla]

This looks good to me, thanks! 🚢