-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block version of Blank Canvas to FSE design picker #58869
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~21 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~4249 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Smoke Testing ThemeRequirementsTested both the editor + frontend Default Content
Block Patterns
Global Styles
Block Settings
|
A few things to note:
Otherwise, everything else lgtm! |
This is blocked until the new version of Blank Canvas is fully launched (theme slug finalized, theme network activated, previous version deprecated, etc.). |
More discussion on p1641331738434800/1641330580.431200-slack-CHN6J22MP. |
f13e943
to
0777724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes proposed in this Pull Request
available-designs-config.json
to include blank canvas block theme.Blockers
headstart
necessaryScreenshots
Testing instructions
Blank Canvas
is a selectable themeBlank Canvas
enabled and smoke test the themeRelated to #58663.