Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block version of Blank Canvas to FSE design picker #58869

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Dec 6, 2021

Changes proposed in this Pull Request

  • Update available-designs-config.json to include blank canvas block theme.
  • Blank Canvas is a selectable theme in the /new FSE beta onboarding design picker

Blockers

  • ✅ No headstart necessary
  • ✅ No demo URL necessary
  • ✅ Network-activated

Screenshots

Screen Shot 2021-12-06 at 17 50 33

Testing instructions

  • Apply branch to local calypso dev environment
  • Visit http://calypso.localhost:3000/new/beta
  • Enroll in the FSE beta
  • Pick a free test domain
  • Verify that Blank Canvas is a selectable theme
  • Create a site with Blank Canvas enabled and smoke test the theme

Related to #58663.

@zaguiini zaguiini added [Goal] Full Site Editing [Feature] Design Picker Picking themes and designs during onboarding. labels Dec 6, 2021
@zaguiini zaguiini requested a review from a team December 6, 2021 20:53
@zaguiini zaguiini self-assigned this Dec 6, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2021
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~21 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       +242 B  (+0.0%)       +2 B  (+0.0%)
entry-main                 -68 B  (-0.0%)      -41 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4249 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
comments              +465 B  (+0.1%)     +310 B  (+0.2%)
media                 -362 B  (-0.0%)     -403 B  (-0.1%)
signup                +242 B  (+0.1%)      +20 B  (+0.0%)
jetpack-connect       +242 B  (+0.0%)      +20 B  (+0.0%)
accept-invite         +242 B  (+0.1%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@zaguiini zaguiini changed the title Add Blank Canvas 2 to FSE design picker Add Blank Canvas 2 to FSE Design Picker Dec 6, 2021
@jeyip
Copy link
Contributor

jeyip commented Dec 15, 2021

Smoke Testing Theme

Requirements

Tested both the editor + frontend

Default Content

  • No broken blocks on initial load

Block Patterns

  • "Gallery with description and a button" pattern looks like its preview
  • "Link in Bio" pattern looks like its preview
  • "Talk to the host" pattern looks like its preview

Global Styles

  • Typography font size, line height, and font weight changes behave as expected
  • Background color, text color, and link colors changes behave as expected
  • Per block global styles (typography + colors) for the Post title block behave as expected

Block Settings

  • Typography font size, line height, and font weight block settings changes behave as expected
  • Background color, text color, and link color block settings changes behave as expected

@jeyip
Copy link
Contributor

jeyip commented Dec 15, 2021

A few things to note:

  • The blank canvas theme displays in the design picker as expected. We discussed renaming the theme though p1639501720216300/1639501360.215400-slack-CHN6J22MP. I'm unsure if we should wait to release this PR or if it's a non-issue.
  • It appears as if this theme isn't network activated yet, so we'll probably want to do that as well.
  • I think we may want to wait until this PR is merged before displaying block themes to users Site Editor: Display editor menu item by default for block themes #58932. It enables the site editor for block themes by default since block themes don't have access to a functional customizer.

Otherwise, everything else lgtm!

@creativecoder
Copy link
Contributor

This is blocked until the new version of Blank Canvas is fully launched (theme slug finalized, theme network activated, previous version deprecated, etc.).

@zaguiini
Copy link
Contributor Author

zaguiini commented Jan 4, 2022

Still not network activated Finally!

More discussion on p1641331738434800/1641330580.431200-slack-CHN6J22MP.

@zaguiini zaguiini force-pushed the add/blank-canvas-2-to-fse-design-picker branch from f13e943 to 0777724 Compare January 18, 2022 16:29
@zaguiini zaguiini changed the title Add Blank Canvas 2 to FSE Design Picker Add block version of Blank Canvas to FSE design picker Jan 18, 2022
@zaguiini zaguiini requested review from jeyip and a team January 18, 2022 16:30
Copy link
Member

@vindl vindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@zaguiini zaguiini merged commit 0430378 into trunk Jan 18, 2022
@zaguiini zaguiini deleted the add/blank-canvas-2-to-fse-design-picker branch January 18, 2022 18:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Picker Picking themes and designs during onboarding. [Goal] Full Site Editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants