-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Site Editing Design Picker: Enable Russell theme #58772
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-22093 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~31 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~24 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Note: Let's hold off on merging this until block errors with Russell have been fixed. #58663 (comment) and #58787 |
I'm no longer seeing the Gutenberg related block validation error with the Russell homepage that I did before (#58787 (comment)). Do you @jeyip ? If not, I think we can go ahead and merge this! |
Confirmed that I don't see block validation errors anymore described in #58787 (comment). 🚢 |
1 similar comment
Confirmed that I don't see block validation errors anymore described in #58787 (comment). 🚢 |
Changes proposed in this Pull Request
available-designs-config.json
to include new Russell block theme./new
FSE beta onboarding design pickerScreenshots
Testing instructions
Related to # #58663