Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editing Design Picker: Enable Russell theme #58772

Merged
merged 6 commits into from
Dec 14, 2021

Conversation

jeyip
Copy link
Contributor

@jeyip jeyip commented Dec 2, 2021

Changes proposed in this Pull Request

  • Update available-designs-config.json to include new Russell block theme.
  • Russell is a selectable theme in the /new FSE beta onboarding design picker

Screenshots

Screen Shot 2021-11-30 at 5 20 56 PM

Testing instructions

  • Apply branch to local calypso dev environment
  • Visit http://calypso.localhost:3000/new/beta
  • Enroll in the FSE beta
  • Pick a free test domain
  • Verify that Russell is a selectable theme
  • Create a site with Russell enabled and smoke test the theme

Related to # #58663

@jeyip jeyip self-assigned this Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

@jeyip jeyip changed the base branch from trunk to add/arbutus-and-russell-to-fse-design-picker December 2, 2021 18:28
@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~31 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       +353 B  (+0.0%)      +31 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~24 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
signup                +353 B  (+0.1%)      +24 B  (+0.0%)
jetpack-connect       +353 B  (+0.0%)      +24 B  (+0.0%)
accept-invite         +353 B  (+0.1%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jeyip jeyip added [Goal] Full Site Editing [Feature] Design Picker Picking themes and designs during onboarding. DO NOT MERGE labels Dec 2, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 2, 2021
@jeyip
Copy link
Contributor Author

jeyip commented Dec 2, 2021

Note:

Let's hold off on merging this until block errors with Russell have been fixed. #58663 (comment) and #58787

Base automatically changed from add/arbutus-and-russell-to-fse-design-picker to trunk December 2, 2021 20:47
@jeyip jeyip removed the DO NOT MERGE label Dec 6, 2021
@creativecoder
Copy link
Contributor

I'm no longer seeing the Gutenberg related block validation error with the Russell homepage that I did before (#58787 (comment)). Do you @jeyip ?

If not, I think we can go ahead and merge this!

@jeyip
Copy link
Contributor Author

jeyip commented Dec 13, 2021

I'm no longer seeing the Gutenberg related block validation error with the Russell homepage that I did before (#58787 (comment)). Do you @jeyip ?

I'll double-check this and merge it before EOD 👍

@jeyip
Copy link
Contributor Author

jeyip commented Dec 14, 2021

If not, I think we can go ahead and merge this!

Confirmed that I don't see block validation errors anymore described in #58787 (comment).

🚢

1 similar comment
@jeyip
Copy link
Contributor Author

jeyip commented Dec 14, 2021

If not, I think we can go ahead and merge this!

Confirmed that I don't see block validation errors anymore described in #58787 (comment).

🚢

@jeyip jeyip merged commit 71396fd into trunk Dec 14, 2021
@jeyip jeyip deleted the add/russell-to-fse-design-picker branch December 14, 2021 06:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Picker Picking themes and designs during onboarding. [Goal] Full Site Editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants