Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-apply "change add a menu link to point to the top level of customier" #55981

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

roo2
Copy link
Contributor

@roo2 roo2 commented Sep 3, 2021

#54583 was deployed and then reverted when I found that the customizer guides were broken. Now that they are fixed, this diff re-applies the original change #54583

Sep-03-2021 19-44-56

@roo2 roo2 requested a review from a team as a code owner September 3, 2021 09:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2021
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

@matticbot
Copy link
Contributor

matticbot commented Sep 3, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~60 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
home                       -449 B  (-0.1%)     -109 B  (-0.1%)
customize                  -159 B  (-0.1%)      -14 B  (-0.0%)
themes                      +18 B  (+0.0%)       +7 B  (+0.0%)
theme                       +18 B  (+0.0%)       +7 B  (+0.0%)
settings-writing            +18 B  (+0.0%)      +10 B  (+0.0%)
settings-performance        +18 B  (+0.0%)       +8 B  (+0.0%)
settings                    +18 B  (+0.0%)       +5 B  (+0.0%)
plans                       +18 B  (+0.0%)       +7 B  (+0.0%)
gutenberg-editor            +18 B  (+0.0%)       +8 B  (+0.0%)
earn                        +18 B  (+0.0%)       +9 B  (+0.0%)
checkout                    +18 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~25 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-sidebar                        +18 B  (+0.0%)       +9 B  (+0.0%)
async-load-calypso-components-web-preview-component        +18 B  (+0.0%)      +10 B  (+0.0%)
async-load-calypso-blocks-inline-help-popover              +18 B  (+0.0%)       +6 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@roo2 roo2 requested a review from a team September 3, 2021 09:58
@p-jackson p-jackson force-pushed the update/update-edit-menu-link-2 branch from dd35798 to 1c7fa26 Compare September 6, 2021 00:52
Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah much better.

@roo2 roo2 merged commit 67275a7 into trunk Sep 6, 2021
@roo2 roo2 deleted the update/update-edit-menu-link-2 branch September 6, 2021 22:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 6, 2021
@enejb
Copy link
Member

enejb commented Nov 3, 2021

On mobile web
this is what I see when I click on the Add a menu.

Can we move the tour so that we show the button that we want the user to tap?

@p-jackson
Copy link
Member

Yes definitely, it seems like there should be a mobile layout rule that makes sure we don't obscure the button. Seems like a good gardening sort of task. Could you add an issue?

@p-jackson
Copy link
Member

Nevermind, just saw D69585-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants