-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premium Content: Display subscriber view to logged in users who have subscribed #45777
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D49931-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
Fantastic, well done @mmtr – and thanks for identifying where the regressions happened ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried with multiple users in different logged-in/out states, all behaved as expected. 🎉
Verified on my end as well! Looks good. |
Changes proposed in this Pull Request
context
property when registering a block in favor of a newusesContext
, while the latter dropped support for thesubmitButtonText
attribute of thejetpack/recurring-payments
block in favor of the innerjetpack/button
block'stext
attribute. This PR updates the code so block is usable again:Testing instructions
/etc/hosts
file and point the addresses below to your WP.com sandbox IP:public-api.wordpress.com
.subscribe.wordpress.com
./wp-content/mu-plugins/0-sandbox.php
file of your WP.com sandbox:cd apps/editing-toolkit && yarn dev --sync
Fixes #45663
Fixes #45498