e2e: Update Gutenberg classes for 8.5 compat #44457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
the
[Status] Needs e2e Testing Gutenberg Edge
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
sirreal
added
[Status] Needs e2e Testing Gutenberg Edge
WunderBart
reviewed
Jul 27, 2020
| ); | ||
| return await driverHelper.verifyTextPresent( | ||
| this.driver, | ||
| By.css( '.editor-post-publish-panel__header-published' ), | ||
| By.css( '.post-publish-panel__postpublish-header' ), | ||
| 'Scheduled' |
There was a problem hiding this comment.
This doesn't seem to be set in 8.5.1 anymore:
| 8.3.0 | 8.5.1 |
|---|---|
 |
 |
There was a problem hiding this comment.
The updated selector matches this element. It seems to match "scheduled" in the text.
It seems like this should work well across versions, but let's see what the tests report.
There was a problem hiding this comment.
It was previously matching the header selector, but I think it's OK to keep it as a check for that summary text (unless there's a separate test for it?). I'd only make it lowercased scheduled in the test to avoid confusion.
sirreal
added
the
[Status] Needs Review
sirreal
added
[Status] Needs Review
fullofcaffeine
approved these changes
Jul 27, 2020
fullofcaffeine
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
Fixes #