Update FSE plugin to version to 1.13

[deBhal]

Changes proposed in this Pull Request

Version bump and changelog.

Testing instructions

This deploy includes quite a number of PRs, so I'm going to ask as many authors as possible to quickly re-test their changes against the release candidate to make sure there are no surprising interactions.

The detailed instructions are in the field-guide here:

• (wpcom) https://wp.me/PCYsg-ly5/#viewing-the-fse-features
• (atomic) https://wp.me/PCYsg-ly5/#atomic-testing

But if you just need the short version:

• Apply code-D46328
• Test on a sandboxed simple-site with appropriate FSE-plugin flags
• Test on an atomic site with and without Gutenberg enabled

Here's the rc plugin link for your convenience fse-build-archive (2.23 MB) (updated to include fix by @akirk)

Please also add any comment you'd like included in changelog here, and I'll add them in before I merge

Changelog entries

• Change the category of FSE blocks from legacy to the updated ones (Updated default block categories for Automattic blocks #43198).
• Add a helper function that can be used to assign categories with older fallbacks.
• Add support for TypeScript tests.
• Update visual style of navigation sidebar.
• Fix navigation sidebar dismiss button in IE.

PRs to test

• Gutenboarding: persist free domain when selecting free plan #43935 @razvanpapadopol
  • wpcom
  • AT
• Gutenboarding: FSE launch store and flow #43983 @razvanpapadopol
  • wpcom
  • AT
• Gutenboarding: Update site launch styling. #44087 @yansern / @razvanpapadopol
  • wpcom
  • AT
• Docs: Use HEAD rather than master for GitHub URIs #43993 @saramarcondes
  • wpcom
  • AT
• Blocks: Polish and update timeline block to support alternating on large screens #41474 @jasmussen / @georgeh
  • wpcom
  • AT
• Remove isLarge prop from Button block in FSE starter-page-templates #44021 @andrewserong
  • wpcom
  • AT
• Nav sidebar scrolls if the items don't fit on the screen #43906 @p-jackson
  • wpcom
  • AT
• Nav sidebar: Remove the page slug which was displayed below the page title #44092 @p-jackson
  • wpcom
  • AT
• Nav sidebar: Add site title and link to the sidebar #44199 @ramon / @p-jackson
  • wpcom
  • AT
• WPCOM Block Editor: show dismiss button in IE 11 #44196 @ramonjd
  • wpcom
  • AT
• Add @automattic/onboarding package to standardize stylesheets & reuse components. #44077 @yansern
  • wpcom
  • AT
• FSE: Update blocks categories #43670 @fullofcaffeine
  • wpcom
  • AT
• Nav sidebar: Update styling to match latest mockup #44127 @p-jackson
  • wpcom
  • AT
• Premium Content: Correct "non-static method call" errors. #44243 @kwight
  • wpcom
  • AT
• Earn: do not register premium content blocks when gutenberg features are not available #44191 @gwwar
  • wpcom
  • AT

Final pre-release checks

• Confirm phpcbf fixes occur in the Github action build log (Should be in Build FSE plugin/Build packages
  

[matticbot]

Test live: https://calypso.live/?branch=update/fse-plugin-to-v-1-13

[matticbot]

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D46328-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[deBhal]

#43670 is merged and #44191 fixes #44160, so we're clear to go ahead now.

[akirk]

@deBhal I have added a commit to this PR that fixes the error:

@automattic/full-site-editing: ./bin/sync-newspack-blocks.sh: line 132: ../../vendor/bin/phpcbf: No such file or directory
@automattic/full-site-editing: phpcbf: !! There was an error executing phpcbf

I last fixed this here: 0cfd9a3 but it looks like in recent builds the "Build packages" step was skipped in favor of "Build dependencies" (Checks log 1.11.0 vs Checks log 1.12.0), I am observing the same in this PR.

This caused the textdomains not to be rewritten to full-site-editing as anticipated, so I hope to have fixed this again and for a longer period :)

Could you please ensure that you see something like @automattic/full-site-editing: phpcbf: A TOTAL OF 77 ERRORS WERE FIXED IN 5 FILES in the Github Action build log before you ship FSE 1.13? Thanks!

[noahtallen]

so I hope to have fixed this again and for a longer period :)

🤦 Sorry that we didn't catch this again. Would it be helpful to add a unit test for this so PRs fail when the textdomain in newspack blocks does not get updated?

[kwight]

@deBhal Serenity's pieces are good to go; we've got some additional followup, but nothing that results in fatals or that should hold up pushing out this version. 👍

[p-jackson]

I've smoke tested the sidebar changes to confirm they're working correctly in this release.

Also checked that the release related changes look good so take this ✅

[akirk]

@noahtallen How would you approach this? We are talking about files that are not committed, just shipped in the ZIP file, plus I'm not sure we can be certain about which files exist, newspack blocks could change their file layout.

[deBhal]

@akirk: I created #44296 with a simple suggestion for fixing the textdomain issue

[sarayourfriend]

Hi @deBhal. My changes are just to CircleCI so can be ✅; no actual changes to the plugin.

[noahtallen]

We are talking about files that are not committed, just shipped in the ZIP file

True... though they should still exist in the local filesystem for any test purposes, so long as we are testing against a "built" version of the plugin! Some ideas...

1. move the check to the build step, and then allow the build step to fail if the textdomain was not translated
2. just test against a fairly stable file, like class-newspack-blocks.php (though I guess that could change to not have any translated strings in it 🤔 )
3. Add a special lint-check in GitHub CI which runs phpcs on full-site-editing-plugin/newspack-blocks-synced-newspack-blocks using the build artifact, and only fails if the textdomain rule fails

Edit: see this PR for my proposed solution: #44323

[fullofcaffeine]

Tested on an FSE-enabled simple site and it looks good. Took into account the changes from Serenity.

In AT sites I couldn't fully test it though. There appears to be a bug preventing FSE from enabling on AT sites, see: #41825. Discussion: p1595373248144700-slack-cylon.

[deBhal]

@fullofcaffeine: I forced the dotcom-fse on on my ephemeral site (see #41825) and tested this release + dotcom-fse (these names are so confusing :/) with and without gutenberg enabled, and it all looks good, so I'm going to go ahead and tick that off:

[georgeh]

The Timeline block changes look good on wpcom simple and Atomic

[deBhal]

Ok, last check is in.

Those signup timeout failures in the e2e tests are known, and not related to this diff, so we're going ahead.

[sirreal]

👋 I've just landed #44357, can I pull it in here?

[sirreal]

I've rebased to pull in #44357.

[deBhal]

I've rebased to pull in #44357.

Ok, I'm going to trust you know what you're doing, and just do an additional smoke test.