Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT: preview into an iFrame element #39628

Merged
merged 30 commits into from
Feb 28, 2020
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
6a26bb5
spt: preview templates refactoring
retrofox Feb 27, 2020
765e3a7
spt: clean code
retrofox Feb 27, 2020
f804fe3
spt: rename debounce constant
retrofox Feb 27, 2020
c034682
Restore square preview images and Safari fix
obenland Feb 27, 2020
8e7d478
Clarify width attribute
obenland Feb 27, 2020
9b7e106
spt: show not selected template message
retrofox Feb 27, 2020
1e2b020
Merge branch 'add/spt-dynamic-preview' of github.com:Automattic/wp-ca…
retrofox Feb 27, 2020
69e82d9
Simplify copy styles using cloneNode rather than manual iterate + copy
getdave Feb 28, 2020
4361e43
Use timeout to allow iframe styles to copy in FF
getdave Feb 28, 2020
2c64eec
Update iframe access to use ref
getdave Feb 28, 2020
bdab253
Consolidate iframe DOM updates via usage of DocumentFragments
getdave Feb 28, 2020
aa1fc01
Prerender iframe to avoid delay when populating with Blocks
getdave Feb 28, 2020
d589675
Use safe timeout HOC
getdave Feb 28, 2020
3ff5315
Use direct iframe ref rather than rely on DOM order
getdave Feb 28, 2020
389d779
Fix missing param in docblock
getdave Feb 28, 2020
605213c
Fix use of invalid `class` property (should be className)
getdave Feb 28, 2020
d0e9016
Mock correct component
getdave Feb 28, 2020
d63445f
Fix comments
getdave Feb 28, 2020
afeb89f
Tweak test for blocks length
getdave Feb 28, 2020
4dfe705
Move custom “BlockEditor” into dedicated component for testing mock p…
getdave Feb 28, 2020
fffece4
Remove commented out code
getdave Feb 28, 2020
00c005f
Rename component import to improve code clarity
getdave Feb 28, 2020
541b8ce
Rename another component import to improve code clarity
getdave Feb 28, 2020
e4769dd
Adds temporary CSS fixes for jetpack slider in the iframe preview
jeryj Feb 28, 2020
fbf80e0
Make sure swiper pagination bullets are centered
jeryj Feb 28, 2020
fe4582e
Removes margins on cover blocks in iframe preview
jeryj Feb 28, 2020
6f96a92
Removes empty paragraph placeholder text from iframe preview
jeryj Feb 28, 2020
9b600ce
Guard against store not being available
getdave Feb 28, 2020
ace2e50
Fix Template Preview test to account for iframe behaviour
getdave Feb 28, 2020
4afe96a
Remove old snapshot
getdave Feb 28, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove old snapshot
getdave committed Feb 28, 2020

Verified

This commit was signed with the committer’s verified signature.
identw Dmitry Sergeev
commit 4afe96ac9f5c58e21a7e16bc0238accd0af8ef31
Original file line number Diff line number Diff line change
@@ -15,19 +15,3 @@ exports[`TemplateSelectorPreview Basic rendering renders the preview and no plac
</div>
</div>
`;

exports[`TemplateSelectorPreview Basic rendering renders the preview when blocks are provided 1`] = `
<div>
<div
class="template-selector-preview "
>
<div>
<iframe
class="editor-styles-wrapper block-iframe-preview"
style="transform: scale( 1 );"
title="Preview"
/>
</div>
</div>
</div>
`;