-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove overlay background color (obsolete due to Gutenberg PR 15974) #34461
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Simple sites are still on Gutenberg v5.8, as we've been unable to land a stable version since; next attempt to update should be v6.1 around July 10th. |
Thanks @kwight! Ok so @frontdevde let's defer this until iteration 5 or whenever 6.1 lands. |
Don't forget we run in core and atomic too. Is there a way to use some condition or classname to detect older versions? |
@marekhrabe With 6.1.1 out now, is this ready to be merged? |
If we don't intend to add any version check as I've mentioned in the last message, I would get this merged. |
We're optimizing for Simple and Atomic only at this point. I think Core not looking optimally is fine for now |
Changes proposed in this Pull Request
Testing instructions
Fixes #34306