Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overlay background color (obsolete due to Gutenberg PR 15974) #34461

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

frontdevde
Copy link
Contributor

BLOCKED: We need to wait for the Gutenberg change to be available on WPCOM

Changes proposed in this Pull Request

Testing instructions

  • Create a new page with the block editor
  • The background-color of the overlay should use the Gutenberg default. No custom override should be present.

Fixes #34306

@frontdevde frontdevde added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Blocked / Hold [Goal] Full Site Editing [Goal] Page Templates labels Jul 4, 2019
@frontdevde frontdevde requested a review from a team July 4, 2019 11:50
@frontdevde frontdevde requested review from a team as code owners July 4, 2019 11:50
@frontdevde frontdevde self-assigned this Jul 4, 2019
@matticbot
Copy link
Contributor

@frontdevde frontdevde removed request for a team July 4, 2019 11:51
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@kwight
Copy link
Contributor

kwight commented Jul 4, 2019

Simple sites are still on Gutenberg v5.8, as we've been unable to land a stable version since; next attempt to update should be v6.1 around July 10th.

@getdave
Copy link
Contributor

getdave commented Jul 5, 2019

Thanks @kwight!

Ok so @frontdevde let's defer this until iteration 5 or whenever 6.1 lands.

@marekhrabe
Copy link
Contributor

Don't forget we run in core and atomic too. Is there a way to use some condition or classname to detect older versions?

@obenland
Copy link
Member

@marekhrabe With 6.1.1 out now, is this ready to be merged?

@marekhrabe
Copy link
Contributor

If we don't intend to add any version check as I've mentioned in the last message, I would get this merged.

@obenland
Copy link
Member

We're optimizing for Simple and Atomic only at this point. I think Core not looking optimally is fine for now

@obenland obenland merged commit 76789bc into master Jul 19, 2019
@obenland obenland deleted the update/starter-page-template-overlay-styles branch July 19, 2019 17:17
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(1P) Remove Custom Modal overlay CSS in favour of new default
6 participants